Skip to content

[ci] Upload autoscaling in K8s test results#2606

Merged
VietND96 merged 1 commit intotrunkfrom
autoscaling-results
Jan 21, 2025
Merged

[ci] Upload autoscaling in K8s test results#2606
VietND96 merged 1 commit intotrunkfrom
autoscaling-results

Conversation

@selenium-ci
Copy link
Member

@selenium-ci selenium-ci commented Jan 21, 2025 •
edited
Loading

This PR contains the results of the autoscaling tests in Kubernetes

@qodo-code-review
Copy link
Contributor

qodo-code-review bot commented Jan 21, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Failed Sessions

All sessions are failing to create in the deployment count test, with 0 total running sessions across all iterations. This indicates a potential configuration or infrastructure issue.

| 1         | 3                    | 0.07 s                | 3                         | 0                  | 0                      | 0                  | 1                    | 0    | 0               |
| 2         | 1                    | 0.06 s                | 1                         | 0                  | 0                      | 0                  | 1                    | 0    | 0               |
| 3         | 2                    | 0.06 s                | 2                         | 0                  | 0                      | 0                  | 1                    | 0    | 0               |
| 4         | 3                    | 0.06 s                | 3                         | 0                  | 0                      | 0                  | 1                    | 0    | 0               |
| 5         | 1                    | 0.05 s                | 1                         | 0                  | 0                      | 0                  | 1                    | 0    | 0               |
| 6         | 2                    | 0.06 s                | 2                         | 0                  | 0                      | 0                  | 1                    | 0    | 0               |
| 7         | 2                    | 0.08 s                | 2                         | 0                  | 0                      | 0                  | 1                    | 0    | 0               |
| 8         | 1                    | 0.08 s                | 1                         | 0                  | 0                      | 0                  | 1                    | 0    | 0               |
| 9         | 3                    | 0.08 s                | 3                         | 0                  | 0                      | 0                  | 1                    | 0    | 0               |
| 10        | 1                    | 0.07 s                | 1                         | 0                  | 0                      | 0                  | 1                    | 0    | 0               |
| 11        | 1                    | 0.06 s                | 1                         | 0                  | 0                      | 0                  | 1                    | 0    | 0               |
| 12        | 1                    | 0.06 s                | 1                         | 0                  | 0                      | 0                  | 1                    | 0    | 0               |
| 13        | 3                    | 0.06 s                | 3                         | 0                  | 0                      | 0                  | 1                    | 0    | 0               |
| 14        | 1                    | 0.08 s                | 1                         | 0                  | 0                      | 0                  | 1                    | 0    | 0               |
| 15        | 3                    | 0.06 s                | 3                         | 0                  | 0                      | 0                  | 1                    | 0    | 0               |
| 16        | 1                    | 0.08 s                | 1                         | 0                  | 0                      | 0                  | 1                    | 0    | 0               |
| 17        | 1                    | 0.08 s                | 1                         | 0                  | 0                      | 0                  | 1                    | 0    | 0               |
| 18        | 1                    | 0.09 s                | 1                         | 0                  | 0                      | 0                  | 1                    | 0    | 0               |
| 19        | 1                    | 0.06 s                | 1                         | 0                  | 0                      | 0                  | 1                    | 0    | 0               |
| 20        | 1                    | 0.06 s                | 1                         | 0                  | 0                      | 0                  | 1                    | 0    | 0               |
Initial Failures

All 6 sessions fail to create in the first iteration but subsequent iterations work normally. This inconsistency in initial session creation should be investigated.

| 1         | 6                    | 0.10 s                | 6                         | 0                  | 0                      | 0                  | 1                    | 0    | 0               |
| 2         | 4                    | 51.12 s               | 0                         | 4                  | 4                      | 4                  | 1                    | 0    | 4               |

@qodo-code-review
Copy link
Contributor

qodo-code-review bot commented Jan 21, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Score
Possible issue
Fix critical session creation failures

The test results show all sessions are failing to create (100% failure rate) with
very low creation times (0.05-0.09s), indicating a critical issue with the
deployment's session creation mechanism that needs investigation.

.keda/results_test_k8s_autoscaling_deployment_count.md [3-4]

-| 1         | 3                    | 0.07 s                | 3                         | 0                  | 0                      | 0                  | 1                    | 0    | 0               |
-| 2         | 1                    | 0.06 s                | 1                         | 0                  | 0                      | 0                  | 1                    | 0    | 0               |
+| 1         | 3                    | 30.07 s               | 0                         | 3                  | 3                      | 3                  | 1                    | 0    | 0               |
+| 2         | 1                    | 25.06 s               | 0                         | 1                  | 4                      | 4                  | 1                    | 0    | 0               |
  • Apply this suggestion
Suggestion importance[1-10]: 9

Why: The suggestion identifies a critical issue where all sessions are failing to create (100% failure rate), which represents a severe functional problem in the deployment's session creation mechanism.

9
Fix chaos test initialization failure

The first iteration shows all 6 sessions failing immediately (0.10s) with no pod
scaling, suggesting a critical initialization problem in chaos conditions that
prevents proper session establishment.

.keda/results_test_k8s_autoscaling_job_count_strategy_default_in_chaos.md [3]

-| 1         | 6                    | 0.10 s                | 6                         | 0                  | 0                      | 0                  | 1                    | 0    | 0               |
+| 1         | 6                    | 45.10 s               | 0                         | 6                  | 6                      | 6                  | 1                    | 0    | 0               |
  • Apply this suggestion
Suggestion importance[1-10]: 9

Why: The suggestion highlights a critical initialization failure in chaos conditions where all 6 sessions fail immediately, indicating a severe problem with the system's resilience under stress.

9

@VietND96 VietND96 merged commit 967cb27 into trunk Jan 21, 2025
1 check passed
@VietND96 VietND96 deleted the autoscaling-results branch January 21, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Review effort [1-5]: 2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@selenium-ci @VietND96